DoctrineExtensions icon indicating copy to clipboard operation
DoctrineExtensions copied to clipboard

Partial DBAL 4.x support

Open mbabker opened this issue 1 year ago • 1 comments

Fixes #2752

This adds support for DBAL 4.x everywhere outside the loggable extension, which isn't really feasible due to the removal of the array type and the data migration required to just change to the JSON type (follow https://github.com/doctrine-extensions/DoctrineExtensions/issues/2502 and https://github.com/doctrine-extensions/DoctrineExtensions/pull/2825 for more on this).

The worst B/C issues here are the removal of the Type::getName() method and the removal of the Connection::PARAM_*_ARRAY constants. The type name replacement (Type::lookupName()) only came in DBAL 3.7 and the constant replacements in DBAL 3.6, so I've bumped the DBAL minimum to use those. Most other changes are just for convenience by using the methods on the DBAL connection to handle type conversions instead of doing that stuff directly in the package code or updating the tests to add required properties for decimal fields.

mbabker avatar Aug 25 '24 19:08 mbabker

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (0632ab1) to head (72510d6). Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
src/AbstractTrackingListener.php 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
+ Coverage   78.75%   78.82%   +0.07%     
==========================================
  Files         163      167       +4     
  Lines        8593     8637      +44     
==========================================
+ Hits         6767     6808      +41     
- Misses       1826     1829       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 19:08 codecov[bot]

Any plans to be merged soon? Thanks

dmitryuk avatar Sep 18 '24 11:09 dmitryuk

Thank you @mbabker!

phansys avatar Oct 06 '24 22:10 phansys

Any plans to be merged soon? Thanks

Sorry for the delay. 3.17.0 was released, including this PR.

phansys avatar Oct 06 '24 23:10 phansys

Wohoo. Thank you

Nyholm avatar Oct 07 '24 07:10 Nyholm