Florian Klein

Results 95 comments of Florian Klein

We have to take care of BC somehow. A simple file split conserving the same namespace would allow this, since autoloading would take care of reassembling the sparse classes.

and here we start to see the problem of having a "Bundle" suffix :)

if you vot for no bundle suffix, you'll have to find a solution to maintain BC. Or maybe we simply don't care about preserving class naming, since the bundle is...

hey there! Thanks for pointing that out. I never really had interest in putting those kind of headers in each file, but it seems discusses a lot on the interwebs...

it's not implemented yet, so it would be a nice addition. However, I often found myself that auto registration is not always helpful as soon as you have custom ctor...

yes, there are better tools for that: php-di and jms/di-extra do it perfectly. The only thing we provide natively is if your class implements ContainerAwareInterface. In that case, you'll still...

yes, that's a missing part of the doc that is very important :/ We're working on some feature files describing very realistically the behavior: https://github.com/KnpLabs/KnpRadBundle/blob/9351cb05257d15a189162b3ebf7a423d76a76ee5/features/csrf_protection.feature#L23 Since a code snippets worth...

#129 should be able to addthe csrf attribute in appropriate requests.

we kept master because we wanted to keep all the previous history of knprad v1. That was to avoid breaking apps of people using knprad v1. Maybe, after all this...