docsify icon indicating copy to clipboard operation
docsify copied to clipboard

fix: Fix duplicate sidebar when include audio file

Open sy-records opened this issue 4 years ago • 3 comments

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Repo settings
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

before after
image image

sy-records avatar Feb 25 '21 02:02 sy-records

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/8UaF2UC3VEdx2pCEW4yZMtfeWCgt
✅ Preview: https://docsify-preview-git-fork-sy-records-fix-compiler-docsify-core.vercel.app

vercel[bot] avatar Feb 25 '21 02:02 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11e5020ddb66346734fb8cae563784168d534e92:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Feb 25 '21 02:02 codesandbox-ci[bot]

I'm having the same issue. When I include more than 1 video file in the page, the sidebar menu will loop for several times if refresh the page or open the page via link. If will be correct if coming from another page. It is very annoying since I need to share the docs link to others and the menu looped like broken.

zenof avatar Mar 25 '21 03:03 zenof