docsify icon indicating copy to clipboard operation
docsify copied to clipboard

chore(deps): bump marked from 1.2.9 to 2.0.0

Open dependabot[bot] opened this issue 4 years ago • 13 comments

Bumps marked from 1.2.9 to 2.0.0.

Release notes

Sourced from marked's releases.

v2.0.0

2.0.0 (2021-02-07)

Bug Fixes

BREAKING CHANGES

  • em and strong tokenizers have been merged into one emStrong tokenizer.
  • code and text tokenizers do not get passed all tokens as a second parameter.
  • No longer supporting IE 11. IE 11 may still work but we are not committed to making sure it works with every update. We still provide an es5 version in lib/marked.js but some pollyfills may be needed for IE 11 in the future.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Feb 09 '21 07:02 dependabot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/7BA56oF8TjJqhhTfR8pNczAuadwH
✅ Preview: https://docsify-previe-git-dependabot-npmandyarnmarked-200-docsi-dffd83.vercel.app

vercel[bot] avatar Feb 09 '21 07:02 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9997779155b214526d04dfd38476f465f43ee714:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Feb 09 '21 07:02 codesandbox-ci[bot]

This should be high priority since marked < 2.0 is vulnerable to ReDOS:

A Denial of Service attack can affect anyone who runs user generated code through marked.

markedjs/marked#1927 https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS

thijstriemstra avatar Feb 16 '21 16:02 thijstriemstra

This should be high priority since marked < 2.0 is vulnerable to DDOS:

A Denial of Service attack can affect anyone who runs user generated code through marked.

markedjs/marked#1927 https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS

thx a lot, we will check it soon. :+1:

Koooooo-7 avatar Feb 16 '21 16:02 Koooooo-7

@Koooooo-7 any idea when this will be merged and released?

thijstriemstra avatar Feb 26 '21 23:02 thijstriemstra

@Koooooo-7 any idea when this will be merged and released?

we need have tests on those changes first, and discuss if we need still support the IE11 in future.

I wonder that if you could provide a case to reproduce the DDos on docsify , it will help a lot :) thx.

Koooooo-7 avatar Feb 27 '21 04:02 Koooooo-7

I wonder that if you could provide a case to reproduce the DDos on docsify , it will help a lot :) thx.

Create a page with the following content:

_______________________________ ____________________ __________________________ a

and you'll see that the page will throw this error:

 Uncaught InternalError: too much recursion
    strong http://unpkg.com/docsify/lib/docsify.min.js:1
    inlineTokens http://unpkg.com/docsify/lib/docsify.min.js:1
    inline http://unpkg.com/docsify/lib/docsify.min.js:1
    lex http://unpkg.com/docsify/lib/docsify.min.js:1
    lex http://unpkg.com/docsify/lib/docsify.min.js:1
    On http://unpkg.com/docsify/lib/docsify.min.js:1
    _renderMain http://unpkg.com/docsify/lib/docsify.min.js:1
    a http://unpkg.com/docsify/lib/docsify.min.js:1
    W http://unpkg.com/docsify/lib/docsify.min.js:1
    _renderMain http://unpkg.com/docsify/lib/docsify.min.js:1
    _fetch http://unpkg.com/docsify/lib/docsify.min.js:1
    then http://unpkg.com/docsify/lib/docsify.min.js:1

Tested on MacOS 10.15.7 with Firefox 86.0

thijstriemstra avatar Feb 27 '21 12:02 thijstriemstra

@thijstriemstra thx a lot ! IMO, it is a content which wrote by users themselves and it doesnt make sense. I dont think it is vulnerable for ReDDos rn. but yea, absolutely, If a user insert a content like this, it will make the site crushed and it needs fix. @docsifyjs/reviewers It is a potential bug, WDYT?

Koooooo-7 avatar Feb 27 '21 13:02 Koooooo-7

Just wondering if there's any ETA when this would be merged, due to the high vulnerability? Thanks!

klsember avatar Mar 10 '21 18:03 klsember

Just wondering if there's any ETA when this would be merged, due to the high vulnerability? Thanks!

Hi. After our discussion on it. it's not the high vulnerability to users, either to docsify. User knows what they write to their own site , it it's under control. We may sync the IE11 supports until v5.

Koooooo-7 avatar Mar 11 '21 00:03 Koooooo-7

I am getting an npm audit report:

npm audit report

marked 1.1.1 - 1.2.9 Severity: moderate Regular Expression Denial of Service - https://npmjs.com/advisories/1623 fix available via npm audit fix --force Will install [email protected], which is a breaking change node_modules/marked docsify >=4.11.5 Depends on vulnerable versions of marked node_modules/docsify

Currently I have docsify 4.12.0.

It would be a good idea to merge this and resolve a security issue.

Yash-Singh1 avatar May 07 '21 18:05 Yash-Singh1

A newer version of marked exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar Jan 15 '22 01:01 dependabot[bot]

Another thing to note before merging this:

No longer supporting IE 11. IE 11 may still work but we are not committed to making sure it works with every update. We still provide an es5 version in lib/marked.js but some pollyfills may be needed for IE 11 in the future.

I think its one of docsify's features to have compatibility with IE11:

  • Compatible with IE11

Yash-Singh1 avatar Jan 15 '22 01:01 Yash-Singh1

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar May 27 '23 05:05 dependabot[bot]