docsify icon indicating copy to clipboard operation
docsify copied to clipboard

header link in github flavored markdown mode.

Open computerphilosopher opened this issue 5 years ago • 3 comments

Bug Report

Steps to reproduce

set 'gfm' attribute to true and make a header link that has a hyphen('-') in it.

What is current behaviour

I have to write in this way

# link to  'part1 - my title'   
[my header link](part1-my-title)

What is the expected behaviour

but when I make header link in github, I have to write in this way.

# link to  'part1 - my title'   
[my header link](part1---my-title)

I think link text should be same as github because I set gfm mode to true.

I reported a issue to markedjs first.

they said new release of docsify could fix this issue.

markedjs was updated in version 4.10.2 but nothing changed.

so I think it is docsify's issue.

Other relevant information

  • [x] Bug does still occur when all/other plugins are disabled?

  • Your OS: MacOS Mojave 10.14.16

  • Node.js version: 13.1.0

  • npm/yarn version: npm 6.12.1

  • Browser version: safari 13.0.4

  • Docsify version: 4.10.2(docsify) 4.4.0(docsify-cli)

  • Docsify plugins:

  <script src="//unpkg.com/prismjs/components/prism-bash.min.js"></script>
  <script src="//unpkg.com/prismjs/components/prism-c.js"></script>
  <script src="//unpkg.com/prismjs/components/prism-cpp.js"></script>
  <script src="//unpkg.com/prismjs/components/prism-java.js"></script>
  <script src="//unpkg.com/docsify-copy-code"></script>
  <script src="https://cdn.jsdelivr.net/npm/docsify-themeable@0"></script>

computerphilosopher avatar Jan 16 '20 05:01 computerphilosopher

We'll need to investigate this.

trusktr avatar Jan 18 '20 17:01 trusktr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '20 18:03 stale[bot]

Hey! Can I work on this?

nawed2611 avatar May 06 '22 11:05 nawed2611