aequery icon indicating copy to clipboard operation
aequery copied to clipboard

ScriptUI Capitalization Consistency

Open runegan opened this issue 9 years ago • 3 comments

Original report by vaporstack (Bitbucket: vaporstack, GitHub: vaporstack).


There are a couple of minor inconsistencies in the casing of ui/container.js -

Notably, AddEditText / AddStatictext have dissimilar casing. Easy enough to fix but probably should be done with a deprecation warning to avoid breaking existing scripts.

Recommend we use the naming and casing as described in JavaScript Tools Guide -

* AddStatictext -> AddStaticText
* AddTreeview -> AddTreeView
* AddListbox -> AddListBox* * 

A little bit annoying to decipher since the tools guide has some inconsistencies in itself, for example

#!javascript

 ProgressBar / Scrollbar

runegan avatar Jun 06 '16 15:06 runegan

Original comment by Rune Gangsø (Bitbucket: runegan, GitHub: runegan).


How should the deprecation warning work? Just throw an error stating: "addListbox has changed name to addListBox"?

runegan avatar Jun 14 '16 07:06 runegan

Original comment by Rune Gangsø (Bitbucket: runegan, GitHub: runegan).


ScriptUI Capitalization Consistency

See #12 I don't know if there is any more inconsistency, that needs to be checked. The previous method names (addListbox, addStatictext and addTreeview)now points to the renamed methods (addListBox, addStaticText and addTreeView) to be backwards compatible.

runegan avatar Sep 13 '16 14:09 runegan

Original comment by Zack Lovatt (Bitbucket: zlovatt, GitHub: zlovatt).


Re: capitalization, there are also inconsistencies in the modules toString() functions;

return "[object aeq.App]"; compared to return "[object aeq.app]";

runegan avatar Apr 06 '17 23:04 runegan