sbom-cli-plugin icon indicating copy to clipboard operation
sbom-cli-plugin copied to clipboard

Fix linting and bouncer issues

Open davidhay1969 opened this issue 2 years ago • 1 comments
trafficstars

Resolving a few linting and bouncer issues

  • Updated internal/logger/logrus.go to handle ioutil deprecation
  • Updated cmd/event_loop.go to handle linting issues
  • Updated .bouncer.yaml to ignore crypto/internal/boring

Signed-off-by: Dave Hay [email protected]

davidhay1969 avatar Dec 25 '22 15:12 davidhay1969

logrus.go change

internal/logger/logrus.go:10:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

event_loop.go change

cmd/event_loop.go:17:1: directive `// nolint:funlen` should be written without leading space as `//nolint:funlen` (nolintlint)
// nolint:funlen
^

.bouncer.yaml change

Unallowable license (OpenSSL) from "crypto/internal/boring"
failed validation
make: *** [Makefile:114: check-licenses] Error 1

davidhay1969 avatar Dec 25 '22 15:12 davidhay1969