machine
machine copied to clipboard
docker
fix openFirewallPorts to build the network name with the same format …
…used in createInstance, allowing the user to pass a fully-qualified url for network and subnetwork resources
Description
https://github.com/docker/machine/pull/4335 added support for fully qualified network and subnetwork names in the google driver. This pr builds on that to fix the formatting of the network name in the openFirewallPorts method.
Currently, the driver will append the fully qualified network name to the globalUrl instead of taking it as-is.
Related issue(s)
- https://github.com/docker/machine/issues/4344
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "master" [email protected]:perryao/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Can we get this? Is anyone yet support docker machine project? I do not think so :)
