libkv
libkv copied to clipboard
docker
Upgrade Go, use modules and enable CI on GitHub Actions
@thaJeztah do you need to approve the new workflow for it to run on this PR or does need to land in master actually? (I've never contributed GitHub Actions setup to repos I don't have admin access to, so I don't know how is that supposed to work!)
See tests results on my fork: https://github.com/errordeveloper/libkv/actions?query=branch%3Aci
They don't run until initially merged, but you can create a PR on your own fork to run it (perhaps there's other tricks that @crazy-max knows to do the same though)
They don't run until initially merged, but you can create a PR on your own fork to run it (perhaps there's other tricks that @crazy-max knows to do the same though)
We must have a dummy workflow on the default branch otherwise it will not triggered. See https://github.com/distribution/distribution/pull/3314
@crazy-max looks like it still refused to run new workflow... let me try to rename it ;)
@crazy-max looks like it still refused to run new workflow... let me try to rename it ;)
ci.yaml is a new workflow I think that's why it's not triggered. So rename dummy.yml > ci.yml and move the content from your ci.yaml. I think it would work as GitHub will detect changes in that workflow (hopefully).
@crazy-max somehow that still doesn't work... I think someone just need to approve the run, but maybe we could merge new workflow instead to make it simpler?
You have created a new dummy.yaml and removed the dummy.yml that's why I think. You have to rename dummy.yml to ci.yml. See https://github.com/docker/libkv/pull/220#issuecomment-996818557.
@errordeveloper Anyway you can check on your fork it seems to fail: https://github.com/errordeveloper/libkv/runs/4562356731?check_suite_focus=true
@crazy-max I'll just remove dummy.yml here; I know that it is still failing, seems like a flaky test and I my simple fix didn't work...