golang-cross icon indicating copy to clipboard operation
golang-cross copied to clipboard

Update to Go 1.14.12

Open tao12345666333 opened this issue 5 years ago • 9 comments

Signed-off-by: Jintao Zhang [email protected]

tao12345666333 avatar Feb 26 '20 17:02 tao12345666333

Any chance of getting this merged or/and updated to 1.14.1? Would be wonderful to get some faster defer statements going :)

Jacalz avatar Apr 07 '20 14:04 Jacalz

ping @thaJeztah PTAL, thanks!

tao12345666333 avatar Apr 07 '20 18:04 tao12345666333

I'd like to hold off for a bit; we're not yet updating our toolchain to Go 1.14, because there's some regressions / incompatibilities with Go 1.14 related tot the preemptive changes made in that release.

thaJeztah avatar Apr 09 '20 19:04 thaJeztah

I would say that it’s time to get this landed now. With 1.15 out of the door, 1.13.x won’t receive updates any more which isn’t ideal from a security standpoint.

Jacalz avatar Aug 13 '20 10:08 Jacalz

rebased.

tao12345666333 avatar Sep 13 '20 13:09 tao12345666333

Sorry, but could we please get this merged soon? It is getting very necessary to get 1.14.10 landed due to the big timezone issue, golang/go/issues/42138 among with 1.13.x not getting any security fixes. This has sat open for almost nine months.

Jacalz avatar Nov 06 '20 09:11 Jacalz

Sorry, but could we please get this merged soon? It is getting very necessary to get 1.14.10 landed due to the big timezone issue, golang/go/issues/42138 among with 1.13.x not getting any security fixes. This has sat open for almost nine months.

ping @thaJeztah Thanks!

tao12345666333 avatar Nov 17 '20 12:11 tao12345666333

Hi, we're at v1.14.12, which is the latest 1.14 version as of today. I would suggest merging now, since all downstream projects that depend on the golang-cross image will gain the ability to automatically support vendored dependencies in Go modules, which is a change that was introduced in Go 1.14

carleeto avatar Dec 02 '20 18:12 carleeto

Not sure how this is being used by Docker - if this is merged, dockercore/golang-cross:1.13.15 would still be on docker hub for use, but those of us who wanted newer could have that as well, no?

jlk avatar Apr 23 '21 17:04 jlk