docs icon indicating copy to clipboard operation
docs copied to clipboard

[misc] nginx/compose: use docker-compose spec v3

Open das7pad opened this issue 6 years ago • 1 comments
trafficstars

Proposed changes

Migrate the docker-compose file of the nginx auth example from v1 to v3.

Unreleased project version (optional)

Related issues (optional)

Followup for #9270


NOTE1: bcrypt is still not supported by the nginx:latest docker image

NOTE2: I tested the example using this minimal nginx config to omit the ssl setup:

events {
  worker_connections  1024;
}

http {
  upstream docker-registry {
    server registry:5000;
  }
  server {
    server_name _;
    listen 443;

    auth_basic "Registry realm";
    auth_basic_user_file /etc/nginx/conf.d/nginx.htpasswd;

    location /v2/ {
      proxy_pass http://docker-registry;
    }
  }
}
# curl testuser:[email protected]:5043/v2/ -i
HTTP/1.1 200 OK
Server: nginx/1.17.3
Date: Thu, 12 Sep 2019 23:30:14 GMT
Content-Type: application/json; charset=utf-8
Content-Length: 2
Connection: keep-alive
Docker-Distribution-Api-Version: registry/2.0
X-Content-Type-Options: nosniff

das7pad avatar Sep 12 '19 23:09 das7pad

Deploy preview for docsdocker ready!

Built with commit 54dad9b8125cfd4c694b4b678c89534f3682276f

https://deploy-preview-9441--docsdocker.netlify.com

GordonTheTurtle avatar Sep 12 '19 23:09 GordonTheTurtle

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment. If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robott avatar Nov 24 '22 01:11 docker-robott

Deploy Preview for docsdocker ready!

Name Link
Latest commit b77ecb645e3b6921adcd6487734e8691090f804f
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/640cbc14369c0e000880a2e2
Deploy Preview https://deploy-preview-9441--docsdocker.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Dec 11 '22 22:12 netlify[bot]

In regards to https://github.com/docker/docs/pull/9441#discussion_r942268827 this is likely still of interest.

/remove-lifecycle stale

das7pad avatar Dec 11 '22 22:12 das7pad

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment. If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robott avatar Mar 11 '23 01:03 docker-robott

In regards to https://github.com/docker/docs/pull/9441#discussion_r942268827 this is likely still of interest.

/remove-lifecycle stale

das7pad avatar Mar 11 '23 17:03 das7pad