docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

[WIP] Fix #2389

Open EFanZh opened this issue 6 years ago • 2 comments

Test cases are missing, I will add test cases later.

EFanZh avatar Jul 30 '19 01:07 EFanZh

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "fix-loading-image" [email protected]:EFanZh/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Jul 30 '19 01:07 GordonTheTurtle

The code looks good.

feliperuhland avatar Jul 31 '19 20:07 feliperuhland