docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Fixed an issue with inaccurate comments.

Open BobDu opened this issue 6 years ago • 1 comments
trafficstars

In container logs , return is bytes or generator iterator of output bytes , not string , the comments is error.

BobDu avatar Jan 23 '19 02:01 BobDu

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "master" [email protected]:Bob-Du/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Jan 23 '19 02:01 GordonTheTurtle

ping @milas

Years have passed, and the issue still exists. Given that this project remains active and is widely used, could you please pay attention to this PR?

BobDu avatar Apr 08 '24 13:04 BobDu

Thank you for the documentation fix.

Pinging on an old PR that has been revised is acceptable but please be respectful. This PR might have existed for 5 years but it was not actually mergeable until recently, as it was missing DCO.

milas avatar Apr 09 '24 20:04 milas