docker-py
docker-py copied to clipboard
docker
Fixing issue #1809
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "master" [email protected]:andreycizov/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354330832
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
@andreycizov Hi, you need to update commit message here: https://github.com/docker/docker-py/pull/1814/commits/e9c6c86e4dee33408ad2a8cec9ac93f14d663b6b
@stasfilin Sorry - didn't get the fact that all of the commits I made need to be signed.
The maintainers of this project object to this pull request as they assume the docker-py objects should not be serializable: https://github.com/docker/docker-py/issues/1809
@MatthiasLohr I have to admit that I completely disagree with their logic as the only reason we can't do that is the implementation of the UNIX socket adapter. Which is easily fixable (given this pull request).
Let me be clear about that: what's the point of supplying me with the deserialized Container objects in the library, if I still need to copy them to another Container object in my code? You're making us do the job twice instead.
You could have made the API much simpler by just allowing us to work directly with the dictionaries. But since you preferred to go the way of abstracting them from us - then why do you then actively try to stop us from doing things?
@feliperuhland Given your reply in #1809 I again disagree with the answer since my specific use case was loading a list of objects from the API in bulk, and then passing them down the queue for processing. Docker-py forced me to simply copy the attributes of these objects, which is not optimal.