docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Published 20 hours ago • verified publisher icon docker

Clear uname/gname when creating tar archive

Open Larsjep opened this issue 8 years ago • 13 comments

To ensure that the cache from docker command client can be reused, we must clear group/user name as the docker client does.

Together with golang/go#20150 this fixes #998

Signed-off-by: Lars Jeppesen [email protected]

Larsjep avatar Apr 30 '17 22:04 Larsjep

Anyone knows what this "janky" check is and why nothing happens with it ?

Larsjep avatar May 02 '17 12:05 Larsjep

Hi @Larsjep

Thanks for working on a fix for this. Any idea when it's likely to be merged?

Thanks

Tom

tomyan avatar May 23 '17 14:05 tomyan

Hi @tomyan,

I'm sorry but I'm also waiting for a response from the maintainers. They might be busy with other stuff, because I can see several other pull requests waiting.

Br Lars

Larsjep avatar May 23 '17 15:05 Larsjep

Thank you @Larsjep !

Sorry about the late response - my understanding is that this patch will not do anything unless it is used with a Docker Engine built with Go 1.9+, of which there has been none so far. Once one such Engine has been released, we can test those changes to ensure they have the expected result, and if confirmed, merge the PR.

shin- avatar Jul 03 '17 18:07 shin-

I may be misreading, but it looks like moby/moby#33935 has re-added the very bits that were intentionally removed in golang/go#20150, in an attempt to fix the test failures (due to cache hashes now being different) seen in moby/moby#33892?

edmorley avatar Sep 01 '17 16:09 edmorley

Hi @shin- and @Larsjep

Docker CE 17.12.0 has just been released, and includes "Bump Go to 1.9.2" for both moby and the cli. See the Runtime section of https://github.com/docker/docker-ce/releases/tag/v17.12.0-ce

Is there a way I can test this patch out?

Thanks for your help!

oskarpearson avatar Dec 28 '17 15:12 oskarpearson

Unfortunately, the docker team decided to reintroduce the incorrect bits to avoid breaking the cache. They said that they already planned to break the cache when introducing buildkit and then correct the bits at that point. But I haven't been able to get an answer on when buildkit would be implemented and that is 4 months ago :(. See moby/moby#33935

Larsjep avatar Dec 28 '17 20:12 Larsjep

looking forward to this. is it stuck indefinitely, or is there still hope?

r631269 avatar Jun 07 '18 18:06 r631269

Any updates on this?

kilianc avatar Jul 26 '18 23:07 kilianc

Bump, also running into this issue

AlJohri avatar Jan 07 '20 20:01 AlJohri

Bump, also running into this issue

Have you tried using buildkit?. That should have been include since Docker 18.06. The docker team promised that they would fix the bits when switching to buildkit. If that is the case this PR should fix the problem. I'm no longer working on the project where I discovered this issue, so I will not have time to test it myself.

Larsjep avatar Jan 08 '20 20:01 Larsjep

No, I haven't tried using buildkit yet. Just the default docker and docker-compose that comes with Docker for Mac (19.03.5).

AlJohri avatar Jan 08 '20 21:01 AlJohri

No, I haven't tried using buildkit yet. Just the default docker and docker-compose that comes with Docker for Mac (19.03.5).

It should be included with that build, but you will need to enable it by setting DOCKER_BUILDKIT=1. See here: https://docs.docker.com/develop/develop-images/build_enhancements/

But I'm quite sure that you will also need the patch from this PR.

Larsjep avatar Jan 08 '20 21:01 Larsjep