docker-install icon indicating copy to clipboard operation
docker-install copied to clipboard

Support to Linux Mint 19.1

Open DaniloNC opened this issue 6 years ago • 3 comments

Although the Linux Mint 19.1 is based on Ubuntu 18.04, the docker-install script recognize this distribution as a debian buster/sid.

This was working until recently but started to give me some problems when using vscode, see comment https://github.com/microsoft/vscode-remote-release/issues/1041#issuecomment-516596330

The https://get.docker.com | sh, when running from a Linux Mint 19.1 should add the ubuntu bionic repo instead of debian buster.

DaniloNC avatar Jul 30 '19 21:07 DaniloNC

Same applies to linux mint 20, it should be treated as ubuntu focal

ptandler avatar Aug 15 '20 20:08 ptandler

I changed the install script to also check /etc/os-release for ID_LIKE (= "ubuntu") and UBUNTU_CODENAME (for mint 20 it's "focal"). This works fine for me in Linux Mint 20 Ulyana See https://github.com/ptandler/docker-install/tree/issue134-mint-support

ptandler avatar Aug 15 '20 21:08 ptandler

I just created a pull request https://github.com/docker/docker-install/pull/185

ptandler avatar Aug 15 '20 21:08 ptandler