compose-cli icon indicating copy to clipboard operation
compose-cli copied to clipboard

Published 20 hours ago • verified publisher icon docker

fix ecs docs reference to service.deployment

Open actualben opened this issue 3 years ago • 4 comments

What I did Changes an entry in the docs/ecs-compose-features.md's "Compose fields mapping" table so that service.deploy.restart_policy is an x instead of a ✓ also removes a note from the service.restart item which is incorrect.

Related issue

fixes #2153 note: this pr was originally for bogus issue #2182

actualben avatar Aug 23 '22 09:08 actualben

OK did the steps recommended by the DCO job docs to add my missing Signed-off-by on the commit: git rebase HEAD~1 --signoff followed by git push --force-with-lease origin fix-2182. Sorry about forgetting that.

actualben avatar Aug 23 '22 09:08 actualben

DCO is still failing unfortunately:

Expected "actualben [[email protected]](mailto:[email protected])", but got "Ben Burke [[email protected]](mailto:[email protected])".

laurazard avatar Aug 23 '22 09:08 laurazard

how about now?

actualben avatar Aug 23 '22 13:08 actualben

Would it be cool to change to this PR so it can close #2153? Apparently service.deploy.restart_policy is not supported in ecs either.

actualben avatar Aug 24 '22 12:08 actualben

I didn't realize this PR was still open and deleted my fork. I think the change is still worth doing because issue 2153 is still open. I've created a replacement PR.

actualben avatar Mar 02 '23 14:03 actualben