cli icon indicating copy to clipboard operation
cli copied to clipboard

Replace deprecated usages of `assert.ErrorType`

Open laurazard opened this issue 1 year ago • 2 comments

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

laurazard avatar Aug 01 '24 10:08 laurazard

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.01%. Comparing base (ddd4c39) to head (508337b). Report is 632 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5312      +/-   ##
==========================================
- Coverage   61.45%   61.01%   -0.45%     
==========================================
  Files         299      296       -3     
  Lines       20855    20847       -8     
==========================================
- Hits        12816    12719      -97     
- Misses       7124     7211      +87     
- Partials      915      917       +2     

codecov-commenter avatar Aug 01 '24 11:08 codecov-commenter

FWIW, I opened a PR to see if un-deprecating is acceptable;

  • https://github.com/gotestyourself/gotest.tools/pull/286

thaJeztah avatar Aug 30 '24 11:08 thaJeztah

New version of gotest.tools was released that un-deprecates this; I opened a PR to update to that version;

  • https://github.com/docker/cli/pull/5808

thaJeztah avatar Feb 09 '25 12:02 thaJeztah

Yayyy 🥳 Will close this.

laurazard avatar Feb 09 '25 21:02 laurazard