cli icon indicating copy to clipboard operation
cli copied to clipboard

WIP: add configurable detach delay to logs

Open laurazard opened this issue 1 year ago • 1 comments
trafficstars

- What I did

Hacky PR for demonstration/discussion purposes only.

Addresses: https://github.com/docker/cli/issues/5305

- How I did it

- How to verify it

  • docker run -d --name bork alpine sh -c "while true; do echo hi; sleep 1; done"
  • docker logs -f --delay 3 bork
  • (in another terminal) docker restart bork

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

laurazard avatar Jul 30 '24 11:07 laurazard

Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.

Project coverage is 61.41%. Comparing base (826fc32) to head (f632123). Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5307      +/-   ##
==========================================
- Coverage   61.45%   61.41%   -0.05%     
==========================================
  Files         299      299              
  Lines       20856    20882      +26     
==========================================
+ Hits        12818    12824       +6     
- Misses       7122     7142      +20     
  Partials      916      916              

codecov-commenter avatar Jul 30 '24 11:07 codecov-commenter