un-skip history test and fix golden mismatches

[imjasonh]

Signed-off-by: Jason Hall [email protected]

As discovered in https://github.com/docker/cli/pull/3779#discussion_r974281026, these tests were skipped because CI doesn't run in UTC. The failures don't seem to require UTC, only updating the golden file's column spacing to match current reality.

- What I did

Un-skipped tests in history_test.go

- How I did it

Removed skip from history_test.go, added t.Run wrappers so that failed assertions didn't stop other tests from running. Updated golden files to match test expectations.

- How to verify it

make dev && make test-unit

- Description for the changelog

Image history tests are no longer skipped on CI.

- A picture of a cute animal (not mandatory but encouraged)

cc @thaJeztah

[codecov-commenter]

Codecov Report

Merging #3781 (f10ecfd) into master (edd51b2) will increase coverage by 0.04%. The diff coverage is n/a.

:exclamation: Current head f10ecfd differs from pull request most recent head f5e224e. Consider uploading reports for the commit f5e224e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3781      +/-   ##
==========================================
+ Coverage   59.28%   59.32%   +0.04%     
==========================================
  Files         288      288              
  Lines       24632    24632              
==========================================
+ Hits        14602    14613      +11     
+ Misses       9160     9148      -12     
- Partials      870      871       +1     

[thaJeztah]

Looks like the second commit is missing a DCO sign-off; when you're updating, could you squash the commits, and fix the sign-off to make the DCO check happy?

Thanks again! Sorry for the delay (had a lot of catching up to do on notifications 😅)

[imjasonh]

Friendly ping. Anything else you'd like to see?

[imjasonh]

I'm not sure why DCO isn't reporting. I'll try closing/reopening and/or re-pushing the change to see if that wakes it up.

[imjasonh]

Another friendly ping. I'm not in any rush to get this done, I just keep noticing it's still open. Anything else blocking?

[imjasonh]

Another friendly ping. I'm not in any rush to get this done, I just keep noticing it's still open. Anything else blocking?

Another one. I'm also fine just dropping this if there isn't interest in testing this. If that's the case though, I can also just delete the test.

[thaJeztah]

let me close/reopen to have a fresh run of CI 🙈

[thaJeztah]

Whoops; looks like I never pressed the "merge" button on this one.

I was just working on a similar test, and it looks like there's an workaround that just never occurred to me; adding a t.SetEnv("TZ", "UTC") to the test will make the test use UTC. I'll do a quick follow-up after this one's merged 👍