cli icon indicating copy to clipboard operation
cli copied to clipboard

#692 Updates builder.md to point out the fact that single-quotes will not unpack vars, resolves #692

Open TheHipbot opened this issue 7 years ago • 3 comments
trafficstars

…unpack variables

- What I did

Updated the docs in builder.md

- How I did it

Edited the md files

- How to verify it

Wait for feedback

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

TheHipbot avatar Oct 21 '18 20:10 TheHipbot

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "692-label-single-quotes" [email protected]:TheHipbot/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Oct 21 '18 20:10 GordonTheTurtle

Codecov Report

Merging #1467 into master will decrease coverage by 0.95%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   55.14%   54.19%   -0.96%     
==========================================
  Files         289      289              
  Lines       19371    19377       +6     
==========================================
- Hits        10683    10502     -181     
- Misses       7996     8199     +203     
+ Partials      692      676      -16

codecov-io avatar Oct 21 '18 20:10 codecov-io

resolves #692

TheHipbot avatar Oct 21 '18 20:10 TheHipbot

Carried by https://github.com/moby/buildkit/pull/3241, can be closed.

crazy-max avatar Oct 31 '22 12:10 crazy-max