php
php copied to clipboard
docker-library
Do not delete source files when debugging
This "oh, but one more thing" is actually part of the reason why we resisted implementing DOCKER_PHP_ENABLE_DEBUG for so long :sweat_smile: :heart:
In this specific case, this is really trivial to implement via docker-php-source extract post-build, so without a stronger justification than "it'd be handy", I'm afraid this one is a likely decline. :bow:
I support this PR. When debug build is enabled, it does not make any sense to remove the sources. I understand the post from @tianon, but let's make developers live not harder.
docker-php-source extract wouldn't quite work for me because I am patching the sources.
Hey @yyny, while reviewing your PR, I'd suggest the following code changes:
https://github.com/docker-library/php/pull/1496
You can also review and apply these suggestions locally on your machine.
Learn more about GitKraken Code Suggest
Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.
Join your team on GitKraken to speed up PR review.
Hey @yyny, while reviewing your PR, I'd suggest the following code changes:
https://github.com/docker-library/php/pull/1496
You can also review and apply these suggestions locally on your machine.
Learn more about GitKraken Code Suggest
Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.
Join your team on GitKraken to speed up PR review.