Jonathan Dobson
Jonathan Dobson
I went ahead and dropped the second commit ( https://github.com/kubernetes-sigs/vsphere-csi-driver/commit/57f8773014c5947dcce1c1040bec90965ee2791a ) since it doesn't affect this issue, it just changes how the driver calls `mkfs`. IMO, we can move forward...
Hi @shalini-b @divyenpatel, do you feel comfortable accepting this change? Or do you have any additional feedback?
Since this has roughly the same approach as https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1377 my comments there can apply to this PR as well :) /ok-to-test
/retest-required
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-edge-zones
/retest-required
/test e2e-aws-ovn-edge-zones
> Maybe instead of adding it as a [project scoped role](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/setup-project.sh#L105), it needs to be added to the service account (gcloud iam service-accounts add-iam-policy-binding "${IAM_NAME}" --member serviceAccount:"${IAM_NAME}" --role roles/iam.serviceAccountuser). >...