firebase-mock icon indicating copy to clipboard operation
firebase-mock copied to clipboard

Published 20 hours ago • verified publisher icon dmurvihill

Typescript definitions

Open sceee opened this issue 5 years ago • 5 comments

Thanks for the lib. Are there typescript typings available somewhere so that firebase-mock can be used in typescript projects?

sceee avatar Feb 19 '20 16:02 sceee

I'll gladly email you mine, but they are nowhere near the quality needed to merge in. I'd love to get a PR!

dmurvihill avatar Feb 20 '20 17:02 dmurvihill

@dmurvihill thanks, that'll be great, maybe we'll get them together to a state ready for a PR. Would it make sense to commit them to a separate branch so I could propose changes to that branch if I would have additions to it?

sceee avatar Feb 22 '20 10:02 sceee

Pushed to dmurvihill:type-definitions. Have at it!

One thing that would be a must is automated tests to make sure we don't cause regressions.

dmurvihill avatar Feb 23 '20 19:02 dmurvihill

@dmurvihill thank you very much, I will have a look at it. Regarding automated tests for typedefs, I have little experience so I will have to see if I can help there.

sceee avatar Feb 25 '20 20:02 sceee

Check this out: https://github.com/SamVerschueren/tsd

dmurvihill avatar Feb 28 '20 20:02 dmurvihill