MXNet.cpp icon indicating copy to clipboard operation
MXNet.cpp copied to clipboard

merging into mxnet repo

Open hjk41 opened this issue 8 years ago • 6 comments

I propose to merge mxnet.cpp into mxnet project.

  1. It will attract more attention to mxnet.cpp.
  2. It will enable integrated test with mxnet, so that future checkins to mxnet will not break mxnet.cpp

hjk41 avatar Feb 12 '17 01:02 hjk41

@lx75249 @zhangchen-qinyinghua

hjk41 avatar Feb 12 '17 01:02 hjk41

The most convinient way is to add a subdirectory (cpp-package) in mxnet's root, like other language bindings (R and scala). In this way, the main work is test integration. (I guess we can also add some hook for regenerating op.h when mxnet is updated? I'm not sure if it's possible in github)

conopt avatar Feb 12 '17 12:02 conopt

I agree with the subdirectory approach. As for the update hook, I guess we can hook it, but not sure if we can execute python script inside the hook. Anyway, let's merge it first, and then try to figure out the hook thing. @lx75249 Could you create a PR to mxnet with the subdirectory?

hjk41 avatar Feb 13 '17 02:02 hjk41

OK. I will do it.

conopt avatar Feb 13 '17 12:02 conopt

I think this should be done ASAP. Because this repo is far behind other interfaces, e.g, Python. Meanwhile, it is really important for industrial envo (e.g, data center), where Python and other dependencies are normally not installed.

qiyuangong avatar Feb 15 '17 05:02 qiyuangong

I agree :)

zhangchen-qinyinghua avatar Feb 27 '17 03:02 zhangchen-qinyinghua