gh-dash
gh-dash copied to clipboard
allow notification display and management
this gh extension: https://github.com/meiji163/gh-notify allows for commandline interaction with notifications. would be useful if this could be integrated into gh-dash, so the display and interaction are done using TUI instead of commandline, and are fro mthe same tool
I think it would be great to integrate GitHub notifications (in general) into gh-dash.
@dlvhdr let me know if you'd be down for me to do some work on this. I'd recommend we design the UI first.
Of course I'm down, sounds great!
This is awesome! Any progress with the design?
Thanks @RoseSecurity for reactivating this old discussion.
I wasn't aware gh-notify existed. I'll take a look at it. From what I can see it's a pure script. So it would be about reverse-engineering what the code does.
Maybe gh-not (hi @nobe4 👋), also in Go, could be a better candidate for anyone interested to bring notifications to gh-dash, or simply to use it directly.
https://github.com/nobe4/gh-not
The code behind gh-not is more than just a notification viewer. So I don't know how much of this codebase would fit into gh-dash.
The main ideas of gh-not are:
-
Hardened notification fetching and caching.
The
/notificationAPI was so flaky for me, it gave me the incentive to write that in the first place. There's a significant portion of the code dedicated only to pulling notifications and their context, and handling a local cache. -
Configured actions, so I could for instance, mark all notifications from
dependabot, asdoneautomatically.rules: - filters: - .author.login == "dependabot[bot]" action: done -
REPL to access the notifications in a TUI.
None of that code is currently exported, but if there's interest, I could make some of that available to others. 🤝
Yeah this would be awesome for me ❤️
Actually I'm not interacting with notifications that much. I even hid the bell icon with a script on the GitHub side since it's so noisy and causes context switches.
My question is, what kind of things do you imagine gh-dash doing here? I can imagine like marking a notification as done, unsubscribing and opening the notification in the GitHub site. but since I'm not an heavy user I would love to hear some feedback.
@zachdaniel @joshmedeski @yuvalif
@dlvhdr for me this is an important github tool. i work on a big project and sometimes I'm not notified directly on changes that i should review. would be great to be able to:
- see thew list of notifications
- be able to look into a notifications
- mark as done
Closing as a duplicate of #141. I will take all feedback into account.