gulp-sass icon indicating copy to clipboard operation
gulp-sass copied to clipboard

Fix for SourceComments including stdin instead of proper file path

Open aphex opened this issue 10 years ago • 4 comments
trafficstars

Resolves https://github.com/dlmanning/gulp-sass/issues/234

aphex avatar May 25 '15 20:05 aphex

sorry for the wait, could you add a test that was previously failing for that to the testsuite?

Keats avatar Jun 09 '15 18:06 Keats

Yes, please add a test for this.

I'm also concerned that passing the file to Node Sass may result in unintended consequences of the raw file being compiled instead of the contents of the file stream. We already have a place in our codebase to transform stdin in to the main file's path (for sourcemaps); please refer to that,

Snugug avatar Jun 24 '15 11:06 Snugug

With the fix in #314, this is now failing. Can you please update?

Snugug avatar Jul 14 '15 12:07 Snugug

@xzyfer are you still interested in this? I rebased it, but unsure if you want to land it: https://github.com/dlmanning/gulp-sass/compare/master...XhmikosR:pr/286

XhmikosR avatar Dec 29 '21 08:12 XhmikosR