gcp_auth icon indicating copy to clipboard operation
gcp_auth copied to clipboard

Supporting service account key format OR user credential formats

Open msdrigg opened this issue 2 years ago • 8 comments

This PR supports parsing both formats in either the GOOGLE_APPLICATION_CREDENTIALS env variable or the ~/.config/gcloud/application_default_credentials.json file.

This is part 1 of the PRs addressing #56

For context see https://github.com/hrvolapeter/gcp_auth/pull/75#issuecomment-1683894661

msdrigg avatar Aug 18 '23 13:08 msdrigg

@djc I need to do real world testing on this part, but is this what you're looking for as of part 1?

msdrigg avatar Aug 18 '23 13:08 msdrigg

Tested this PR with real world keys

  • Tested with GOOGLE_APPLICATION_CREDENTIALS and ~/.config/gcloud/application_default_credentials.json and verified the new tagged enum is used in both cases
  • Tested with service account key and user creds, and verified that I can make API calls

msdrigg avatar Aug 18 '23 18:08 msdrigg

This should be ready for final checks at this point

msdrigg avatar Aug 24 '23 23:08 msdrigg

This is on my list to review, but it's been busy. Hope to get to it soon.

djc avatar Aug 25 '23 08:08 djc

No rush. Just wanted to make sure it wasn't waiting on me.

msdrigg avatar Aug 25 '23 13:08 msdrigg