gcp_auth icon indicating copy to clipboard operation
gcp_auth copied to clipboard

Published 20 hours ago • verified publisher icon djc

Add TokenProvider::email() method

Open djc opened this issue 1 year ago • 1 comments

Because TokenProvider is a trait (and not sealed), this is technically a breaking change. Since there's just been a breaking change a month ago, not sure if we want a breaking change for this again? If so, maybe also turn it into an enum instead of a trait...

r? @valkum

djc avatar Jul 11 '24 11:07 djc

Wondering if any users make use of the trait. If not, it does make sense to exchange this with an enum. The types of auth are finite, and I currently can't see any need to be able to specify your own token provider. Maybe we should release the change together with the trait -> enum conversion as a -rc.0 first?

valkum avatar Jul 15 '24 12:07 valkum