channels_redis icon indicating copy to clipboard operation
channels_redis copied to clipboard

Adding type hints to channel_redis

Open LuisGMM opened this issue 8 months ago • 2 comments

Hey folks, great work here, thanks a lot!

I was wondering if there are any plans to add type hints to the project :D

LuisGMM avatar Apr 09 '25 18:04 LuisGMM

We're open to it, but no one is actively working on it.

If you're interested in working on this, I'd be delighted to review Pull Requests.

The basic plan I have is:

  1. Enable mypy inside tox (like how it works on asgiref: https://github.com/django/asgiref)
  2. Add types to a few simple (obvious) cases
  3. Progressively add more and more coverage
  4. Add a py.typed file once we get enough coverage

Each step should be a separate PR (3 can be many PRs), so if you just want to get the ball rolling with 1 and maybe 2 I think that would be great!

bigfootjon avatar Apr 25 '25 05:04 bigfootjon

@bigfootjon This is my first time participating in this repository. I apologize in advance if I have violated any rules. I have implemented typehints, so could you please review it?

https://github.com/django/channels_redis/pull/417

iwakitakuma33 avatar May 29 '25 14:05 iwakitakuma33