channels_redis
channels_redis copied to clipboard
Adding type hints to channel_redis
Hey folks, great work here, thanks a lot!
I was wondering if there are any plans to add type hints to the project :D
We're open to it, but no one is actively working on it.
If you're interested in working on this, I'd be delighted to review Pull Requests.
The basic plan I have is:
- Enable mypy inside tox (like how it works on asgiref: https://github.com/django/asgiref)
- Add types to a few simple (obvious) cases
- Progressively add more and more coverage
- Add a
py.typedfile once we get enough coverage
Each step should be a separate PR (3 can be many PRs), so if you just want to get the ball rolling with 1 and maybe 2 I think that would be great!
@bigfootjon This is my first time participating in this repository. I apologize in advance if I have violated any rules. I have implemented typehints, so could you please review it?
https://github.com/django/channels_redis/pull/417