channels_redis icon indicating copy to clipboard operation
channels_redis copied to clipboard

Published 20 hours ago • verified publisher icon django

Renamed internal methods in core channel layer.

Open carltongibson opened this issue 8 months ago • 1 comments

Internal API was renamed in Channels 4.2.1

Initial rename will work for new versions, but not older channels versions. Maybe just need to make channels>=4.2.1. a requirement.

carltongibson avatar Mar 30 '25 07:03 carltongibson

Will add compatibility fallbacks in https://github.com/django/channels/pull/2145 — we can resolve this more leisurely.

carltongibson avatar Mar 30 '25 09:03 carltongibson

@andrewgodwin @carltongibson what is the status of this, folks? can it be merged / released by chance? Can we make channels>=4.2.1 in the new release?

shcheklein avatar Jul 17 '25 04:07 shcheklein

@shcheklein Channels has fallbacks here. Are you hitting an error?

carltongibson avatar Jul 21 '25 17:07 carltongibson

@carltongibson no, no errors. Tons of warnings on our CI.

shcheklein avatar Jul 21 '25 19:07 shcheklein

Ok, sure. So you can filter those in the short run.

This PR needs a bit of work to be merged. We're currently testing all the way back to Channels 3 and various versions of the Redis python dependency. All of that would need removing from the tox and GHA configs. Etc. If you'd fancy picking that up it would be great.

carltongibson avatar Jul 21 '25 19:07 carltongibson

@shcheklein It turns out I got a moment. Here you go: https://pypi.org/project/channels-redis/4.3.0/

carltongibson avatar Jul 22 '25 13:07 carltongibson

@carltongibson amazing, thank you!!

shcheklein avatar Jul 22 '25 20:07 shcheklein