rtcclient icon indicating copy to clipboard operation
rtcclient copied to clipboard

Published 20 hours ago • verified publisher icon dixudx

Improved the handling of cookies.

Open ryou-ojima-psd opened this issue 3 years ago • 4 comments

Hello. I've improved rtcclient's use of cookies. Before the improvement, communication with the RTC server was performed while the unnecessary character string was set in the cookie of the HTTP-Header. I think this implementation is more secure. I hope you like it.

ryou-ojima-psd avatar Sep 06 '22 00:09 ryou-ojima-psd

Please wait to merge. I may have found a bug in this code.

ryou-ojima-psd avatar Sep 12 '22 02:09 ryou-ojima-psd

Sorry. There was a problem with how to set the cookie when not redirecting, so I fixed it.

ryou-ojima-psd avatar Sep 12 '22 03:09 ryou-ojima-psd

@ojima-ryou Please feel free to ping when this PR is ready. Thanks.

cc @gpongelli for the cookie handling part, this could be useful for backward compatibility.

dixudx avatar Mar 28 '23 02:03 dixudx

cc @gpongelli for the cookie handling part, this could be useful for backward compatibility.

Sure. Before the final review, I suggest to rebase this PR .

gpongelli avatar Mar 28 '23 05:03 gpongelli