tsconfig-paths icon indicating copy to clipboard operation
tsconfig-paths copied to clipboard

Suggestion: outsource `tsconfig.json` loading

Open OliverJAsh opened this issue 6 years ago • 6 comments

In the past we've ran into bugs around this, so it might be better to outsource it.

E.g. https://github.com/TypeStrong/tsconfig

OliverJAsh avatar Oct 31 '19 14:10 OliverJAsh

IIRC we actually used that package in the very beginning but then we had feature requests for inheritance and comments which, at least at that time, the tsconfig package did not support. So we moved to parsing with a custom JSON package to support comments and added our own inheritance functionality.

jonaskello avatar Nov 01 '19 11:11 jonaskello

You're right—that package still does not support config inheritance (extends). Perhaps we should extract the code that's already in this library into a separate repository, so others can benefit from our work. 😄

OliverJAsh avatar Nov 01 '19 11:11 OliverJAsh

Yes that sounds like a good idea :-). Perhaps the tsconfig package is accepting PRs so we can add the features to that package?

jonaskello avatar Nov 01 '19 11:11 jonaskello

FYI: https://github.com/TypeStrong/tsconfig/pull/27

NickBolles avatar Nov 05 '19 15:11 NickBolles

@OliverJAsh @jonaskello If either of you want to maintain that package, let me know! Happy to add you as owners.

blakeembrey avatar Nov 08 '19 02:11 blakeembrey

If y'all update TypeScript support to 3.2+ you can use tsc --showConfig to automatically generate the entire config. https://www.typescriptlang.org/docs/handbook/release-notes/overview.html#the-new---showconfig-flag

chanceaclark avatar Mar 11 '21 16:03 chanceaclark