guide icon indicating copy to clipboard operation
guide copied to clipboard

Published 20 hours ago • verified publisher icon discordjs

Create guide for seeking audio resource

Open Fyphen1223 opened this issue 2 years ago • 11 comments

Create a guide for seeking audio resources.

Please describe the changes this PR makes and why it should be merged: Explain how to seek audio resources with raw discord.js and @discordjs/voice Many questions about seeking are posted on discord.js guild, and there's no guide about seeking. So I created this.

Fyphen1223 avatar Jun 16 '23 03:06 Fyphen1223

ESLint is kinda...

Fyphen1223 avatar Aug 01 '23 00:08 Fyphen1223

I'm afraid but could you run ESLint one more time? I have fixed all of the error and warning.

Fyphen1223 avatar Aug 01 '23 00:08 Fyphen1223

Thanks bro

Fyphen1223 avatar Aug 01 '23 01:08 Fyphen1223

k it seems like I've fixed all reviews you sent

Fyphen1223 avatar Aug 01 '23 01:08 Fyphen1223

so I have to wait until ESLint approval and merge

Fyphen1223 avatar Aug 01 '23 01:08 Fyphen1223

Hey I'm really sorry but could you run ESLint one more time

Fyphen1223 avatar Aug 24 '23 08:08 Fyphen1223

Sorry could you re-run ESLint check

(Why ESLint says readability is unnecessary)

Fyphen1223 avatar Aug 25 '23 00:08 Fyphen1223

Thank you so much for running so many ESLint check

Fyphen1223 avatar Aug 25 '23 11:08 Fyphen1223

Personally I'd be against having this as its own article. A more general Popular Topics > prism-media guide would make sense. On its own, this just feels like a guide for FFmpeg; one that already exists at that. This and "Decoding an Opus stream" as examples would cover the only two features of prism-media that realistically would need to be implemented separately from @discordjs/voice as of right now. As a side note, it could also be mentioned that @discordjs/voice already depends on prism-media and presumably shouldn't be installed separately for the same reason one shouldn't install the other subpackages separately.

ducktrshessami avatar Nov 28 '23 17:11 ducktrshessami

@ducktrshessami Yeah, that's true enough, but honestly, this will eventually fit in voice section. Because adding content like this in popular topics does not related to discord.js directly. Adding this in voice section (because u know how do you use these things in other part of discord.js bot developing) will be better in my opinion.

Fyphen1223 avatar Dec 08 '23 00:12 Fyphen1223

I wasn't referring to the "Popular Topics" section of the main guide. I agree that a guide about prism-media is more relevant in the Voice guide. I am simply opposed to this as a standalone article. A new "Popular Topics" section can be added since this isn't directly related to @discordjs/voice. If you do agree I'd definitely like to see this rewritten before being merged.

I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it?

Fyphen1223 avatar Dec 09 '23 10:12 Fyphen1223