discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

chore(lint): turn on `curly` again

Open vladfrangu opened this issue 6 months ago • 3 comments

Please describe the changes this PR makes and why it should be merged:

Each commit does a specific change only, so you can review just one of them. This just turns on curly again

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

vladfrangu avatar Jun 13 '25 21:06 vladfrangu

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Oct 5, 2025 1:17pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 5, 2025 1:17pm

vercel[bot] avatar Jun 13 '25 21:06 vercel[bot]

Codecov Report

:x: Patch coverage is 63.63636% with 232 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.77%. Comparing base (612c49b) to head (8dc1692). :warning: Report is 94 commits behind head on main.

Files with missing lines Patch % Lines
packages/voice/src/networking/Networking.ts 0.00% 55 Missing :warning:
packages/voice/src/networking/DAVESession.ts 0.00% 37 Missing :warning:
packages/structures/src/bitfields/BitField.ts 18.51% 22 Missing :warning:
...actions/src/releasePackages/generateReleaseTree.ts 0.00% 18 Missing :warning:
packages/core/src/client.ts 0.00% 18 Missing :warning:
packages/voice/src/VoiceConnection.ts 63.63% 16 Missing :warning:
packages/voice/src/audio/AudioPlayer.ts 50.00% 9 Missing :warning:
packages/rest/src/lib/handlers/Shared.ts 0.00% 8 Missing :warning:
packages/rest/src/lib/utils/utils.ts 70.83% 7 Missing :warning:
packages/voice/src/receive/VoiceReceiver.ts 70.83% 7 Missing :warning:
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10931      +/-   ##
==========================================
+ Coverage   44.32%   44.77%   +0.44%     
==========================================
  Files         313      313              
  Lines       18026    18455     +429     
  Branches     1791     1879      +88     
==========================================
+ Hits         7990     8263     +273     
- Misses      10024    10184     +160     
+ Partials       12        8       -4     
Flag Coverage Δ
brokers 25.88% <0.00%> (-0.42%) :arrow_down:
builders 80.21% <100.00%> (+0.01%) :arrow_up:
collection 100.00% <100.00%> (ø)
core 0.92% <0.00%> (-0.01%) :arrow_down:
formatters 99.69% <100.00%> (+0.03%) :arrow_up:
proxy 65.88% <ø> (ø)
rest 86.92% <56.09%> (-0.64%) :arrow_down:
structures 83.87% <15.62%> (-1.32%) :arrow_down:
util 43.28% <ø> (ø)
utilities 5.90% <0.00%> (-0.40%) :arrow_down:
voice 59.05% <38.49%> (-1.34%) :arrow_down:
ws 35.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 13 '25 21:06 codecov[bot]

I think I fundamentally disagree with this rule for many of the cases it changes here, especially when combined with padding-line-between-statements enabled for after multline blocks.

A couple of the changes made I do like (I never noticed them and it indeed makes it more readable). The majority change 2+ lines of consecutive short-circuiting into exponentially more lines which makes it really hard to tell what is going on (every line becomes 4 with no easily readable and clear separation between checks and functional code)

ckohen avatar Oct 22 '25 10:10 ckohen