discord-api-docs icon indicating copy to clipboard operation
discord-api-docs copied to clipboard

Added invite type

Open fbrettnich opened this issue 1 year ago • 7 comments
trafficstars

Added the invite type based on the OpenAPI specification and api response for guild, group and friend invites

fbrettnich avatar Dec 09 '23 21:12 fbrettnich

Both additional invite types are not relevant for bots

depends on the bot... you could say that about enough other things as well

fbrettnich avatar Dec 09 '23 23:12 fbrettnich

What about moderation bots which filter out certain invite types (disallow guild invites but allow friend invites) only? This is just one out of many use cases for this option.

Walledgarden avatar Dec 09 '23 23:12 Walledgarden

This PR looks great to me!

@Lulalaby You should clarify that what you say is strictly your opinion, this is data returned from an endpoint which bots most definitely use, it's useful as stated above.

quinchs avatar Dec 10 '23 04:12 quinchs

The documentation proposal is fine as is. Like @quinchs said, you can access this information from a public endpoint. That's a valid enough reason to document it, regardless of whether bot developers will use it or not.

i0bs avatar Dec 10 '23 04:12 i0bs

this field should be documented, but for some reason, it was previously rejected in #4334 and #4746

can we get clarification on what happened there, and can this field get documented?

advaith1 avatar Dec 10 '23 04:12 advaith1

Yeah you're right @quinchs.

Sorry for that. I was half asleep writing that. I should've noted that this is my own opinion and I should've definitely provided the context like advaith did.

Personally I agree that it'd be nice to have documented generally, but since it got rejected a few times my hopes are not that high.

Sorry again! 🙏💕

Lulalaby avatar Dec 10 '23 16:12 Lulalaby

btw it is already in the OpenAPI specification, it should also be in the API documentation

fbrettnich avatar Mar 17 '24 19:03 fbrettnich