JDA icon indicating copy to clipboard operation
JDA copied to clipboard

Removes unnecessary recalculation

Open koply opened this issue 4 years ago • 6 comments

Pull Request Etiquette

Changes

  • [x] Internal code
  • [ ] Library interface (affecting end-user code)
  • [ ] Documentation

Description

Removed recalculation of all listeners on registration at AnnotatedEventManager. Also added the varargs for listener registrar method. A usable edit with no negative effects.

The token cannot be empty. Because pre-checked field. Removed unnecessary check.

koply avatar Nov 04 '21 16:11 koply

Should we add unit tests for this?

MinnDevelopment avatar Nov 06 '21 12:11 MinnDevelopment

I don't think it should be. My attempts works well. The MessageListenerExample.java works fine.

koply avatar Nov 06 '21 12:11 koply

Nothing like that will happen.

https://github.com/DV8FromTheWorld/JDA/blob/development/src/main/java/net/dv8tion/jda/internal/utils/config/AuthorizationConfig.java

bump.

koply avatar Nov 10 '21 04:11 koply

I guess, but well

Sanduhr32 avatar Nov 11 '21 15:11 Sanduhr32

This needs to be rebased against master

DV8FromTheWorld avatar Apr 15 '22 02:04 DV8FromTheWorld

Could you rebase this on master?

MinnDevelopment avatar May 20 '22 13:05 MinnDevelopment

Superseded by #2454

MinnDevelopment avatar Jun 03 '23 14:06 MinnDevelopment