structurizr-dsl-intellij-plugin icon indicating copy to clipboard operation
structurizr-dsl-intellij-plugin copied to clipboard

Support multi line separator

Open goto1134 opened this issue 1 year ago • 6 comments

Fixes #110

goto1134 avatar Apr 01 '24 18:04 goto1134

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.11%. Comparing base (9980790) to head (d6e30ce). Report is 35 commits behind head on main.

Files Patch % Lines
...structurizr/dsl/psi/impl/SDAnimationBlockImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   67.70%   69.11%   +1.40%     
==========================================
  Files          48       45       -3     
  Lines         703      654      -49     
  Branches      213      195      -18     
==========================================
- Hits          476      452      -24     
+ Misses         99       95       -4     
+ Partials      128      107      -21     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 04 '24 19:04 codecov[bot]

I don't think we need to cover this generated class with tests.

goto1134 avatar Apr 06 '24 06:04 goto1134

@dirkgroot , what do you think about this change?

goto1134 avatar Apr 14 '24 16:04 goto1134

@goto1134 I'm sorry for the delay. Unfortunately I currently don't have a lot of time available to review your PR. I'll try to take at look at this sometime in the upcoming 2 weeks.

dirkgroot avatar Apr 19 '24 13:04 dirkgroot

@dirkgroot , I rebased it to the master to make sure it is still working. Could you please take a look?

goto1134 avatar Mar 04 '25 13:03 goto1134