Inline mode (probably) doesn't work exactly as people expected.

[el-hoshino]

trafficstars

Here's an example: https://github.com/el-hoshino/QuickshaRe/pull/11

With danger-swiftlint, it can put a review comment right onto the exact line of that warning/error when inline-mode is turned on, which is very easy to find where is wrong, and I guess probably most people would expect this kind of comment when they turn inline-mode on. https://github.com/el-hoshino/QuickshaRe/pull/11#discussion_r368292012

But unfortunately danger-xcode_summary's inline-mode can only leave a normal warning with a link to that file/line along with all other warnings/errors that danger produces. So if there're a number of danger's warnings it's easy to miss the warnings produced by Xcode. https://github.com/el-hoshino/QuickshaRe/pull/11#issuecomment-576002087

So it would be very helpful if danger-xcode_summary plugin can also support putting a comment onto the exact line 😃

danger-swiftlint's inline-mode implementation is here: https://github.com/ashfurrow/danger-ruby-swiftlint/blob/38ff6e27123565e30660724877ead279f7cd87e4/lib/danger_plugin.rb#L140

[diogot]

We just merged #51, let me know if we can close this issue.

[el-hoshino]

@diogot Thanks for merging!

Unfortunately I tried again with the PR above, and seems nothing changed...

The version is latest 0.5.2

+ gem install danger-xcode_summary
Successfully installed danger-xcode_summary-0.5.2
Parsing documentation for danger-xcode_summary-0.5.2
Done installing documentation for danger-xcode_summary after 0 seconds
1 gem installed

[thomasjoulin]

@diogot if I understand correctly, #51 adds the full file path (https://github.com/diogot/danger-xcode_summary/pull/51/files#diff-b922e84caed4009276a6db5646cef94bR140) whereas danger-swiftlint trims the directory portion (https://github.com/ashfurrow/danger-ruby-swiftlint/blob/38ff6e27123565e30660724877ead279f7cd87e4/lib/danger_plugin.rb#L307)

I may be wrong, and have never worked on a plugin so just commenting here if it helps. Let me know if you want me to attempt to fix it instead (may take longer :p)

[diogot]

Hi @thomasjoulin, thanks for the notes. I'm not able to dedicate much time to this project lately, so it would be great if could help on this!