react-virtualized-tree icon indicating copy to clipboard operation
react-virtualized-tree copied to clipboard

Make filter container indexSearch prop optional in types

Open connorholyday opened this issue 5 years ago • 2 comments

The new indexSearch prop introduced for FilteringContainer in #123 is great and has a default so if I'm not mistaken it should be listed as optional in the types.

My TypeScript is throwing a tantrum at the moment because it's expecting me to pass a custom function for this

Thanks for all the work on this package!

connorholyday avatar Jun 12 '20 18:06 connorholyday

Coverage Status

Coverage remained the same at 94.498% when pulling 24b5cfc099089ccc8d218f82bdd94c911b35676d on connorholyday:patch-1 into dfaaf7402d56a3eaf1034fbebfc86770d41f3700 on diogofcunha:master.

coveralls avatar Jun 12 '20 18:06 coveralls

@diogofcunha It would be great if this could be merged :)

jeremypeters avatar Feb 12 '21 16:02 jeremypeters