OldTwitter icon indicating copy to clipboard operation
OldTwitter copied to clipboard

Profile link color fails to sync and default link color only shows in settings page

Open TorutheRedFox opened this issue 2 years ago • 13 comments

The sync issue is related to CORS (settings:1 Access to fetch at 'https://dimden.dev/services/twitter_link_colors/v2/set' from origin 'https://twitter.com' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.) but I have no idea why the default link color doesn't persist.

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

What browser? Never had issue with CORS since im intercepting these headers

dimdenGD avatar Jul 02 '23 16:07 dimdenGD

Ungoogled Chromium

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

I'll do some additional debugging on my end see if it's caused here, but I don't think that CORS would cause issues with the default color not persisting across pages

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

Default link color not persisting could only happen if you reload extension and change it after extension context was invalidated

dimdenGD avatar Jul 02 '23 16:07 dimdenGD

i'm not doing that though

it does persist in the settings page but in other places i have to override the css variable myself

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

although the extension context is invalidating itself because of an error at scripts/helpers.js:845

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

there's also this error image

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

Can you show full error

dimdenGD avatar Jul 02 '23 16:07 dimdenGD

image

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

Try downloading and installing again, i pushed possible fix

dimdenGD avatar Jul 02 '23 16:07 dimdenGD

only thing that seems to have got fixed is the color box for the profile link color no longer being black and actually being my profile link color from back in the day

TorutheRedFox avatar Jul 02 '23 16:07 TorutheRedFox

I'm not sure about color not showing anywhere else but settings page bug, but CORS bug should be fixed in beta

dimdenGD avatar Jul 02 '23 23:07 dimdenGD

ok the CORS bug is fixed but yeah the color not showing anywhere else still persists

TorutheRedFox avatar Jul 03 '23 18:07 TorutheRedFox

This was fixed

dimdenGD avatar Jul 10 '23 12:07 dimdenGD