OldTwitter icon indicating copy to clipboard operation
OldTwitter copied to clipboard

Loading private profiles properly

Open 0xWerz opened this issue 2 years ago • 1 comments
trafficstars

#133

Preview:

image

Inspired from the 2015 UI:

image

0xWerz avatar Jul 04 '23 14:07 0xWerz

This doesn't follow proper format of locale files. Every line can only have message, description and example fields (in this case it's just message with multiple different lines). Also you shouldn't use Google Translate or whatever tool you used, only add English and if you know any other language you can translate it yourself.

dimdenGD avatar Jul 04 '23 15:07 dimdenGD

I think the description field is necessary; there are two blocks of text, the title and the bottom description, which are different in font and size. What do you think?

0xWerz avatar Jul 06 '23 06:07 0xWerz

"Description" field is used to help translators give context, not to be used in code itself. Just make another line for text you have inside "description" and put it inside "message". Also please move new lines to the bottom of locale file so it can be easily seen as new thing to translate.

dimdenGD avatar Jul 06 '23 09:07 dimdenGD

I have simply replicated what you've done with the hasnt_tweeted field.

document.getElementById('no-tweets').innerHTML = `
          <h3>${LOC.hasnt_tweeted.message.replace('$SCREEN_NAME$', `<span>${pageUser.screen_name}</span>`)}</h3>
          <p>${LOC.when_theyll_tweet.message}</p>
        `;

"hasnt_tweeted": { "message": "@$SCREEN_NAME$ hasn't tweeted", "placeholders": { "screen_name": { "content": "loading" } } },
"when_theyll_tweet": { "message": "When they do, their Tweets will show up here." },

0xWerz avatar Jul 06 '23 10:07 0xWerz

Thank you!

dimdenGD avatar Jul 06 '23 14:07 dimdenGD