ethereum icon indicating copy to clipboard operation
ethereum copied to clipboard

Add sever select to Ethereum status page

Open digitaldonkey opened this issue 7 years ago • 8 comments

The Server status page at admin/reports/ethereum currently works only for the default server.

With the refactored Server settings there should be a SELECT field on top, where you can switch the status page to any ACTIVE server. Ideally we can reach every server config with admin/reports/ethereum/<id>

image

For reference. The Servers are Drupal config Entities now. With the following properties.

https://github.com/digitaldonkey/ethereum/blob/1a77d2644a84c7587ecca54596d252a624e9dec3/config/optional/ethereum.ethereum_server.infura_ropsten.yml#L1-L6

digitaldonkey avatar Mar 13 '18 22:03 digitaldonkey

Updated in https://github.com/digitaldonkey/ethereum/commit/70ff1a19968d7b05df7dd18a1f6658408561a1a6#diff-28ce30da17769de7dd390cff37d71c70

The screen now different. A server selector would still be interesting.

image

digitaldonkey avatar Apr 25 '18 15:04 digitaldonkey

I'd be keen to help on this, if it's still relevant? So is the idea to have something like this, possibly without the submit button so that it automatically submits when changed:

image

...where you can switch the status page to any ACTIVE server.

By 'active' do you mean servers that are enabled (is_enabled: true)?

foxtrotcharlie avatar Sep 02 '18 18:09 foxtrotcharlie

@foxtrotcharlie that looks great! I think that screenshot is exactly what @digitaldonkey wanted to have on this page.

By 'active' do you mean servers that are enabled (is_enabled: true)?

Yup :)

amateescu avatar Sep 02 '18 21:09 amateescu

Great. Do you use a Drupal rendered Select? It looks a little unstyled.

Default value should be the current default server and all active servers should be selectable. We could also parameterize the page like reports/ethereum/machine_name

Would be happy for a PR.

digitaldonkey avatar Sep 07 '18 11:09 digitaldonkey

Thanks for the feedback @digitaldonkey & @amateescu! Yes, it is a Drupal rendered select. Working on parameterising the page. Will submit PR once done.

foxtrotcharlie avatar Sep 07 '18 18:09 foxtrotcharlie

Would one of you mind having a look here please: https://github.com/digitaldonkey/ethereum/pull/35 ?

I have some questions. Thanks!

foxtrotcharlie avatar Sep 07 '18 21:09 foxtrotcharlie

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

jeffanthony avatar Nov 25 '18 16:11 jeffanthony

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

They both are config entities. Just without a UI implemented. You are welcome to add it.

Can you elaborate on how it would improve the usefulness from your perspective?

digitaldonkey avatar Nov 27 '18 14:11 digitaldonkey