Joel Dice
Joel Dice
> To get back to the main subject, I just remembered I wondered why you use atomic types and mutex in the PR since `wasip2` is single-threaded? Is it because...
> I'd suggest trying to figure out what the API looks like for users as the next step. @vikanezrimaya's [proposal](https://gist.github.com/vikanezrimaya/037101dc7b28de37ef03a47569213236#api-based-on-the-old-server-push-proposal) looks fine to me, and could easily be implemented using...
> After a good night of sleep, I realised the name of the PR should probably mention that it only adds support for established `wasi:sockets` so it's clear that we...
@seanmonstar in order to avoid any wasted effort as I continue to work on this PR, would you mind commenting on whether vikanezrimaya's [proposed public API](https://gist.github.com/vikanezrimaya/037101dc7b28de37ef03a47569213236#api-based-on-the-old-server-push-proposal) looks appropriate to you?
> Can we split this up in multiple prs as this seems to do multiple things. > > 1. A minimal pr that adds support for v2, no adding of...
> @jeffparsons this is waiting on an action on [#1836 (review)](https://github.com/tokio-rs/mio/pull/1836#pullrequestreview-2367086886). We currently don't have the capacity to review a pr of this size, so it needs to be split...
Thanks for the feedback, @Thomasdezeeuw ! > `poll_oneoff` seems to have been changed to `poll`, except that wasi now allocates for the result, which we do not want. That's an...
@pimeys @fbjork I'll try to summarize the situation as I understand it (see the earlier comments for details): @Thomasdezeeuw feels this is not the right approach and would prefer a...
> Right. So instead of implementing our own module, we just use the unix module? Correct. > It should just work if we have the corresponding wit imported to wasmtime?...
> @dicej how should the wakers be created in wasip2? There's some abstractions in the `wasi` crate e.g. for [pollables](https://docs.rs/wasi/0.14.1+wasi-0.2.3/wasi/io/poll/struct.Pollable.html) that could be used here. But how does this fit...