opencommit icon indicating copy to clipboard operation
opencommit copied to clipboard

bug: checkIsLatestVersion doesnt work as expected

Open di-sukharev opened this issue 2 years ago • 4 comments

the function checkIsLatestVersion always returns that version is not latest..

di-sukharev avatar Mar 21 '23 07:03 di-sukharev

anybody could fix that?

di-sukharev avatar Mar 21 '23 07:03 di-sukharev

hey @di-sukharev I'm not able to reproduce this bug on my end.

Steps I took to reproduce:

  1. Clone the opencommit repo.
  2. Build the project and run npm link.
  3. Open a dummy project and run npm link opencommit.
  4. I uncommented the needed lines in cli.ts
  5. when running with 1.1.22 as the version number in the package.json no message pops up as expected
  6. when I change the version number in the package.json to something <1.1.22 I get the message as expected.

Let me know if I'm not following correctly.

matt-degraffenreid avatar Mar 23 '23 12:03 matt-degraffenreid

thanks bro,

it works when tested locally, but it shows the message all the time in prod

here is how it goes for me — when i install latest npm i -g opencommit@latest and run oc --version i see not the latest version, but the version before latest, that's why message is displayed all the time. I believe it's due to some npm latest tag management.

image

di-sukharev avatar Mar 24 '23 02:03 di-sukharev

Stale issue message

github-actions[bot] avatar May 03 '23 21:05 github-actions[bot]