opencommit icon indicating copy to clipboard operation
opencommit copied to clipboard

feat: ✨ add OCO_EMOJI_POSITION_BEFORE_DESCRIPTION

Open ThomasSanson opened this issue 1 year ago • 4 comments
trafficstars

Hello @di-sukharev,

I have submitted this pull request wherein I have made several amendments to your opencommit project.

  1. I have introduced a new configuration key OCO_EMOJI_POSITION_BEFORE_DESCRIPTION that allows users to customise the position of the emoji within the commit message. This provides users with greater flexibility in formatting their commit messages.

  2. I have updated the instructions within generateCommitMessageFromGitDiff.ts to reflect this new option.

  3. I have also updated the README.md file to include instructions on how to utilise the OCO_EMOJI_POSITION_BEFORE_DESCRIPTION configuration. This configuration allows users to determine where the GitMoji should be placed within the commit message.

  4. I have updated the assistant to accommodate the new OCO_EMOJI_POSITION_BEFORE_DESCRIPTION configuration. The assistant now generates commit messages based on the emoji position specified by the user.

  5. Lastly, I have updated the package version from 2.4.2 to 3.0.4 to reflect these new modifications and improvements.

I would like to emphasise that I have tested these modifications locally and everything appears to be functioning as expected. The results are visible in the commit.

However, I would like to draw your attention to the fact that the documentation for contributing to the project is somewhat sparse. This could make access to contribution more challenging for new contributors. I believe it would be beneficial to enhance this aspect to facilitate community contribution.

Thank you for your time and consideration. I eagerly await your feedback on my pull request.

Close #219

ThomasSanson avatar Jan 04 '24 15:01 ThomasSanson

Stale pull request message

github-actions[bot] avatar Feb 13 '24 21:02 github-actions[bot]

@di-sukharev, may I kindly request that you assume responsibility for this pull request ?

Indeed, it appears that each time you approve another pull request, it leads to git conflicts on this one. To prevent such occurrences, it seems prudent for you to manage this task, thereby facilitating a more autonomous and direct resolution of the issue.

ThomasSanson avatar Mar 23 '24 09:03 ThomasSanson

@di-sukharev, may I kindly request that you assume responsibility for this pull request ?

Indeed, it appears that each time you approve another pull request, it leads to git conflicts on this one. To prevent such occurrences, it seems prudent for you to manage this task, thereby facilitating a more autonomous and direct resolution of the issue.

ThomasSanson avatar Jun 21 '24 18:06 ThomasSanson

Will manage when i have time ;) thank you

di-sukharev avatar Jun 21 '24 18:06 di-sukharev