opencommit icon indicating copy to clipboard operation
opencommit copied to clipboard

fix(config.ts): fix config priority

Open hydrotho opened this issue 2 years ago • 3 comments
trafficstars

Problem Description

In this project, according to the README documentation, local configuration should have a higher priority over the global configuration. However, in practice, it was observed that the local config wasn't overriding the global config as expected. Upon investigation, I identified that the issue originated from a logical error in the getConfig() function in the src/commands/config.ts file.

Changes

To address this issue, I have made necessary modifications to the getConfig() function. These changes ensure that the local config correctly overrides the global config.

Testing and Validation

To validate the effectiveness of this fix, I conducted a series of tests including various combinations of global and local configurations. These tests have confirmed that the modified code now aligns with the expected behavior as described in our README.

hydrotho avatar Nov 13 '23 03:11 hydrotho

Stale pull request message

github-actions[bot] avatar Jan 16 '24 21:01 github-actions[bot]

hi @hydrotho great job! thank you! could you solve the hanging conflict and i merge it

di-sukharev avatar Jul 04 '24 08:07 di-sukharev

should be fixed here there was a refactoring https://github.com/di-sukharev/opencommit/pull/391, please fix conflicts

di-sukharev avatar Aug 27 '24 14:08 di-sukharev