opencommit icon indicating copy to clipboard operation
opencommit copied to clipboard

Feat #226: Implement Confirm-Commit and Confirm-Push Flags for Improved User Experience

Open malpou opened this issue 2 years ago • 18 comments

In this pull request, we have introduced new functionality to streamline the user's interaction with the CLI tool. This enhancement focuses on two main aspects: committing and pushing actions, which can now be confirmed upfront with the use of flags.

Changes:

  • Update in cli.ts: Introduced confirmCommitFlag and confirmPushFlag as command-line flags. These flags provide a means for users to confirm commit and push actions at the start of the process. As a result, they will no longer need to confirm these actions manually each time they occur, greatly improving the user experience.
  • Enhancement in commit.ts: Added support for the newly introduced confirmCommitFlag and confirmPushFlag. If the flags are set to true, the commit and push actions proceed automatically without requiring user confirmation. If the flags are false or not provided, the user is prompted to confirm these actions. This modification ensures seamless integration of the new flags with existing functionalities.

We believe that this update will significantly improve the experience of our users by making the commit and push processes more streamlined and user-friendly.

Issue #226

malpou avatar Jul 20 '23 11:07 malpou

Any update about this feature?

ionutz89 avatar Jul 26 '23 14:07 ionutz89

@ionutz89 Still waiting for someone to take a look at my PR

malpou avatar Jul 27 '23 13:07 malpou

+1

dev-mtjoy avatar Jul 27 '23 19:07 dev-mtjoy

@di-sukharev ?

dev-mtjoy avatar Jul 27 '23 19:07 dev-mtjoy

will get to it soon <3

di-sukharev avatar Aug 24 '23 04:08 di-sukharev

@malpou what is the example to use it, is it like oco --confirm-commit?

di-sukharev avatar Aug 24 '23 04:08 di-sukharev

Any update? Need this badly

charanjit-singh avatar Aug 26 '23 08:08 charanjit-singh

@malpou what is the example to use it, is it like oco --confirm-commit?

Yes, that's the though it was mentioned in an issue #226

malpou avatar Aug 29 '23 06:08 malpou

@malpou i dont think that so long message is really an optimal ux, i would go with a shorter flag like oco -f (make sure -f is not in git itself, i dont remember)

di-sukharev avatar Sep 03 '23 04:09 di-sukharev

@malpou i dont think that so long message is really an optimal ux, i would go with a shorter flag like oco -f (make sure -f is not in git itself, i dont remember)

Agree with that, but what do you mean by "not in git itself" ? Are you talking about this command, for example: git push -f ? If yes, this param exists on the git push.

@Christophe-Chantraine-djm-digital, yep i meant what you described, but i think if we do oco --f it would still be first processed by opencommit and we can manage the expected behaviour.

So, fixing the conflict, making the flags shorter (--f is good), then building npm run build and testing locally npm start --f should be all. I will merge when you are sure all is tested <3

di-sukharev avatar Sep 05 '23 05:09 di-sukharev

The flags are suitable and tested now! @di-sukharev

Notes:

  • When testing you need to use npm start -- --cm --cp else params are not parsed to our CLI tool.
  • Flags in cleye can't be shorter than 2 chars.

Flags:

  • --cm : Confirm commit message
  • --cp: Confirm push

Readme updated aswell

malpou avatar Sep 06 '23 14:09 malpou

@di-sukharev Any blockers on this?

malpou avatar Sep 12 '23 14:09 malpou

Stale pull request message

github-actions[bot] avatar Oct 22 '23 21:10 github-actions[bot]

@malpou im so sorry this got closed, do you want to merge it? if so — please solve the conflict and i will get to it asap

di-sukharev avatar Feb 28 '24 05:02 di-sukharev

@malpou i've solved the readme conflict, could you check im not missing anything please and lets merge it!

di-sukharev avatar Feb 29 '24 03:02 di-sukharev

@malpou please check it so we can merge it quickly 🚀

dangnhdev avatar Mar 12 '24 17:03 dangnhdev

@malpou please solve the conflicts, i will merge, test and ship in the next version

di-sukharev avatar Mar 18 '24 04:03 di-sukharev

Sad this never made it in. Means I need to continue to maintain my fork.

JUSTINMKAUFMAN avatar Jun 17 '24 17:06 JUSTINMKAUFMAN

:(

di-sukharev avatar Jun 17 '24 17:06 di-sukharev