capture-app icon indicating copy to clipboard operation
capture-app copied to clipboard

feat: [DHIS2-18310] enable non-Gregorian calendars in views & lists & forms

Open alaa-yahia opened this issue 11 months ago • 3 comments

Implements DHIS2-18310 & DHIS2-18311 & DHIS2-18309 & DHIS2-18868

  • Modified clientToList, clientToForm and clientToView converters to handle local format conversions (DHIS2-18310)
  • Modified FormToClient converter to handle ISO format (DHIS2-18309)
  • Ensure that all “Last updated” calculations are working when local calendar is used
  • Ensure all date pickers (form and working list) are using local calendar.
  • Enable non-Gregorian calendars in working list filters DHIS2-18311
  • Fix search for a trackedEntity by a DATETIME & AGE attributes DHIS2-18868

alaa-yahia avatar Dec 05 '24 00:12 alaa-yahia

Hi @alaa-yahia, I noticed two issues with the Age field:

  1. When selecting a date from the calendar, the year, months, and days are filled with incorrect values. (i.e. In the video below, I selected today's date from the Ethiopian calendar, so the year, months, and day should have been filled with 0).
  2. When typing a value into the days field, the calendar is filled with the gregorian value of the date.

https://github.com/user-attachments/assets/9f7fe558-3e3b-4a0b-beb5-500032bc9d74

In the video above I used the Ethiopian calendar. Can you have a look? Thank you!

simonadomnisoru avatar Dec 12 '24 16:12 simonadomnisoru

@simonadomnisoru I've pushed bug fixes addressing your feedbacks. Could you take another look when you have a time? Thank you

alaa-yahia avatar Jan 16 '25 01:01 alaa-yahia

🚀 Deployed on https://deploy-preview-3900.capture.netlify.dhis2.org

github-actions[bot] avatar Feb 21 '25 11:02 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud[bot] avatar Feb 26 '25 11:02 sonarqubecloud[bot]

:tada: This PR is included in version 101.29.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhis2-bot avatar Feb 26 '25 12:02 dhis2-bot