dhewm3 icon indicating copy to clipboard operation
dhewm3 copied to clipboard

Drop 3DNow! Simd code

Open tyabus opened this issue 3 years ago • 5 comments

I don't think we need this anymore, even linux kernel is dropping it and AMD dosent seem to support them either, so what's the point of keeping it?

tyabus avatar Feb 16 '22 12:02 tyabus

What's the point in removing it? I never even touched that code.

Linux kernel dropping it is irrelevant, as it's Windows+MSVC-only anyway

DanielGibson avatar Feb 20 '22 05:02 DanielGibson

I don't think we need this anymore, even linux kernel is dropping it and AMD dosent seem to support them either, so what's the point of keeping it?

Then it wont run on 3DNow equipped hardware. Well it will, but without the resulting 3DNow speed enhancements.

paulwratt avatar Feb 21 '22 10:02 paulwratt

What's the point in removing it?

3DNow was deprecated over a decade ago. Supporting hardware that far back as well as current systems isn't likely to be maintainable so removing it all together probably makes sense.

SingingBush avatar Sep 14 '22 18:09 SingingBush

dont take it out.

if you want to remove it from code, then record it as a patch in the repo, along with a note as to the hash (and/or link) when it was removed. That way at least someone can come along later and update it later if they feel like it.

3DNow was deprecated over a decade ago.

not a good enough reason, especially if you are a quake playing owner of a working 3DNow system.

paulwratt avatar Sep 15 '22 02:09 paulwratt

It ain't broken, so don't fix it :) And yes, on old Athlon64 and Athlon X2 systems 3DNow makes a difference. Only a few frames per second, however in some situations - especially the big outdoor scenes in RoE - they can decide between unplayable stuttering or slow but somewhat okay. My shiny dual-socket Opteron X2 265 with 1.8 GHz was a good example for that.

Yamagi avatar Sep 15 '22 07:09 Yamagi